From de0a37b2481576cd7817ca21186adc0751fb8b63 Mon Sep 17 00:00:00 2001 From: Jan Vaclav Date: Wed, 3 Dec 2025 10:19:52 +0100 Subject: [PATCH 1/3] build: fix rhel version detection in configure_for_system --- contrib/fedora/rpm/configure-for-system.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/fedora/rpm/configure-for-system.sh b/contrib/fedora/rpm/configure-for-system.sh index bcf619c645..b5dee01a43 100755 --- a/contrib/fedora/rpm/configure-for-system.sh +++ b/contrib/fedora/rpm/configure-for-system.sh @@ -202,7 +202,7 @@ if [ -z "$P_FEDORA" -a -z "$P_RHEL" ] ; then P_FEDORA="$x" P_RHEL=0 else - x="$(grep -q "ID=fedora" /etc/os-release && sed -n 's/VERSION_ID=//p' /etc/os-release)" + x="$(grep -q 'ID="rhel"' /etc/os-release && sed -n 's/^VERSION_ID="*\([0-9]*\).*/\1/p' /etc/os-release)" if test "$x" -gt 0 ; then P_FEDORA=0 P_RHEL="$x" From 55f96057c6d676c17f76c3210bdd0cf614399121 Mon Sep 17 00:00:00 2001 From: Jan Vaclav Date: Wed, 3 Dec 2025 10:22:57 +0100 Subject: [PATCH 2/3] build/configure_for_system: disable building with team on rhel10+ --- contrib/fedora/rpm/configure-for-system.sh | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/contrib/fedora/rpm/configure-for-system.sh b/contrib/fedora/rpm/configure-for-system.sh index b5dee01a43..b5b92d3621 100755 --- a/contrib/fedora/rpm/configure-for-system.sh +++ b/contrib/fedora/rpm/configure-for-system.sh @@ -293,6 +293,10 @@ if [ -z "$P_MODEM_MANAGER_1" ] ; then fi fi +if [ -z "$TEAM" ] && [ "$P_RHEL" -ge 10 ] ; then + P_TEAM=0 +fi + if bool "$P_DEBUG" ; then P_CFLAGS="-g -Og -fexceptions${P_CFLAGS:+ }$P_CFLAGS" else From ae134ca9f4742217f3c90bc8b3fd878e42719cc6 Mon Sep 17 00:00:00 2001 From: Jan Vaclav Date: Wed, 3 Dec 2025 10:27:50 +0100 Subject: [PATCH 3/3] build/configure_for_system: stop building with ifcfg_rh support It has been deprecated for a long time, so it would be probably fine to stop building with it enabled. RHEL 9 is excluded since it still supports the ifcfg-rh format. --- contrib/fedora/rpm/configure-for-system.sh | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/contrib/fedora/rpm/configure-for-system.sh b/contrib/fedora/rpm/configure-for-system.sh index b5b92d3621..e52e372bca 100755 --- a/contrib/fedora/rpm/configure-for-system.sh +++ b/contrib/fedora/rpm/configure-for-system.sh @@ -173,6 +173,7 @@ P_WIFI="${WIFI-1}" P_WWAN="${WWAN-1}" P_TEAM="${TEAM-1}" P_BLUETOOTH="${BLUETOOTH-1}" +P_IFCFG_RH="${IFCFG_RH-0}" P_NMTUI="${NMTUI-1}" P_NM_CLOUD_SETUP="${NM_CLOUD_SETUP-1}" P_OVS="${OVS-1}" @@ -293,10 +294,14 @@ if [ -z "$P_MODEM_MANAGER_1" ] ; then fi fi -if [ -z "$TEAM" ] && [ "$P_RHEL" -ge 10 ] ; then +if [ -z "$TEAM" ] && [ "${P_RHEL-0}" -ge 10 ] ; then P_TEAM=0 fi +if [ -z "$IFCFG_RH" ] && [ -n "$P_RHEL" ] && [ "$P_RHEL" -le 9 ] ; then + P_IFCFG_RH=1 +fi + if bool "$P_DEBUG" ; then P_CFLAGS="-g -Og -fexceptions${P_CFLAGS:+ }$P_CFLAGS" else @@ -407,7 +412,7 @@ meson setup\ -Ddbus_conf_dir="$P_DBUS_SYS_DIR" \ -Dtests=yes \ -Dvalgrind=no \ - -Difcfg_rh=true \ + -Difcfg_rh="$(bool_true "$P_IFCFG_RH")" \ -Difupdown=false \ $(args_enable "$P_PPP" -Dppp=true -Dpppd="$D_SBINDIR/pppd" -Dpppd_plugin_dir="$D_LIBDIR/pppd/$P_PPP_VERSION") \ $(args_enable "$(bool_not_true "$P_PPP")" -Dppp=false ) \