settings: fix assertion when updating default wired connection

The connection is expected to have the NM_GENERATED flag, since it has
a default wired device.

Fixes: d35d3c468a ('settings: rework tracking settings connections and settings plugins')

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/471
This commit is contained in:
Beniamino Galvani 2020-06-17 10:01:07 +02:00
parent fd34fe50a2
commit 4aefad5673

View file

@ -1996,11 +1996,10 @@ nm_settings_update_connection (NMSettings *self,
*/
device = nm_settings_connection_default_wired_get_device (sett_conn);
if (device) {
nm_assert (cur_in_memory);
nm_assert (!NM_FLAGS_ANY (nm_settings_connection_get_flags (sett_conn),
NM_SETTINGS_CONNECTION_INT_FLAGS_NM_GENERATED
| NM_SETTINGS_CONNECTION_INT_FLAGS_VOLATILE
| NM_SETTINGS_CONNECTION_INT_FLAGS_EXTERNAL));
nm_assert (NM_FLAGS_HAS (nm_settings_connection_get_flags (sett_conn),
NM_SETTINGS_CONNECTION_INT_FLAGS_NM_GENERATED));
default_wired_clear_tag (self, device, sett_conn, FALSE);