fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-01-04 05:10:17 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

ppp: downgrade warning about repeated SetIfindex calls from ppp plugin

Browse source 
In src/ppp/nm-pppd-plugin.c, it seems that pppd can invoke
phasechange(PHASE_RUNNING:) multiple times. Hence, the plugin
calls SetIfindex multiple times too. In nm-ppp-manager.c, we
want to make sure that the ifindex does not change after it
was set once. However, calling SetIfindex with the same ifindex
is not something worth warning. Just log a debug message and nothing.

Maybe the plugin should remember that it already set the ifindex,
and avoid multiple D-Bus calls. But it's unclear that that is desired.
For now, just downgrade the warning.
This commit is contained in:
Thomas Haller 2018-09-11 21:54:48 +02:00
parent 4d11eba8c5
commit 4a4439835d
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/ppp/nm-ppp-manager.c
View file

@ -441,7 +441,10 @@ impl_ppp_manager_set_ifindex (NMDBusObject *obj,
_LOGD ("set-ifindex %d", (int) ifindex);
if (priv->ifindex >= 0) {
_LOGW ("can't change the ifindex from %d to %d", priv->ifindex, (int) ifindex);
if (priv->ifindex == ifindex)
_LOGD ("ignore repeated calls setting ifindex to %d", (int) ifindex);
else
_LOGW ("can't change the ifindex from %d to %d", priv->ifindex, (int) ifindex);
goto out;
}