From 468ca67a1fd088494693a110d01ce1d5e5c2517a Mon Sep 17 00:00:00 2001 From: Dan Williams Date: Wed, 28 Jan 2009 11:49:28 -0500 Subject: [PATCH] ppp: always use 'noauth' Since NM is really only a client of the provider's PPP server, and since NM doesn't have any authentication information to authenticate the remote peer anyway. Some providers don't set up their servers to allow clients to ask for authentication from the remote peer either. --- src/ppp-manager/nm-ppp-manager.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/ppp-manager/nm-ppp-manager.c b/src/ppp-manager/nm-ppp-manager.c index 6badbeb5e6..e2f58f5094 100644 --- a/src/ppp-manager/nm-ppp-manager.c +++ b/src/ppp-manager/nm-ppp-manager.c @@ -804,8 +804,12 @@ create_pppd_cmd_line (NMPPPManager *self, if (nm_setting_ppp_get_baud (setting)) nm_cmd_line_add_int (cmd, nm_setting_ppp_get_baud (setting)); - if (nm_setting_ppp_get_noauth (setting)) - nm_cmd_line_add_string (cmd, "noauth"); + /* noauth by default, because we certainly don't have any information + * with which to verify anything the peer gives us if we ask it to + * authenticate itself, which is what 'auth' really means. + */ + nm_cmd_line_add_string (cmd, "noauth"); + if (nm_setting_ppp_get_refuse_eap (setting)) nm_cmd_line_add_string (cmd, "refuse-eap"); if (nm_setting_ppp_get_refuse_pap (setting))