From 44fee0f6fff42773aa73a9a46220db697907751f Mon Sep 17 00:00:00 2001 From: Beniamino Galvani Date: Thu, 6 Aug 2015 16:57:15 +0200 Subject: [PATCH] udev-rules: only invoke ethtool for existing interfaces ethtool may cause the auto-loading of a kernel module for non-existing interface-names. Avoid that by checking whether such an interface exists. This is inherently racy. --- data/85-nm-unmanaged.rules | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/85-nm-unmanaged.rules b/data/85-nm-unmanaged.rules index aefab5c461..f8d95097ff 100644 --- a/data/85-nm-unmanaged.rules +++ b/data/85-nm-unmanaged.rules @@ -6,7 +6,7 @@ SUBSYSTEM!="net", GOTO="nm_unmanaged_end" # Determine ID_NET_DRIVER if there's no ID_NET_DRIVER or DRIVERS (old udev?) ENV{ID_NET_DRIVER}=="?*", GOTO="nm_unmanaged_driver" DRIVERS=="?*", GOTO="nm_unmanaged_driver" -PROGRAM="/bin/sh -c '/usr/sbin/ethtool -i $env{INTERFACE} |/bin/sed -n s/^driver:\ //p'", RESULT=="?*", ENV{ID_NET_DRIVER}="%c" +PROGRAM="/bin/sh -c 'test -e "/sys/class/net/$env{INTERFACE}" && /usr/sbin/ethtool -i "$env{INTERFACE}" | /bin/sed -n s/^driver:\ //p'", RESULT=="?*", ENV{ID_NET_DRIVER}="%c" LABEL="nm_unmanaged_driver" # VirtualBox host networking. Out-of-tree driver that looks like an ordinary