fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-01-03 16:20:14 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

ndisc: ignore IPv6 RA PIOs if preferred lifetime > valid lifetime

Browse source 
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2117
This commit is contained in:
Kyle Ouellette 2025-01-23 20:53:54 +00:00 • committed by Beniamino Galvani
parent e983e8a46f
commit 42b95fad79
1 changed files with 16 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
src/core/ndisc/nm-lndp-ndisc.c
View file

@ -218,10 +218,22 @@ receive_ra(struct ndp *ndp, struct ndp_msg *msg, gpointer user_data)
/* Address */
if (r_plen == 64 && ndp_msg_opt_prefix_flag_auto_addr_conf(msg, offset)) {
const guint32 valid_time = ndp_msg_opt_prefix_valid_time(msg, offset);
const guint32 preferred_time =
NM_MIN(ndp_msg_opt_prefix_preferred_time(msg, offset), valid_time);
const NMNDiscAddress address = {
const guint32 valid_time = ndp_msg_opt_prefix_valid_time(msg, offset);
const guint32 preferred_time = ndp_msg_opt_prefix_preferred_time(msg, offset);
NMNDiscAddress address;
/*
* RFC 4862 Section 5.5.3 states:
* c) If the preferred lifetime is greater than the valid lifetime,
* silently ignore the Prefix Information option. A node MAY wish to
* log a system management error in this case.
*/
if (preferred_time > valid_time) {
_LOGW("skipping PIO - preferred lifetime > valid lifetime");
continue;
}
address = (NMNDiscAddress) {
.address = r_network,
.expiry_msec = _nm_ndisc_lifetime_to_expiry(now_msec, valid_time),
.expiry_preferred_msec = _nm_ndisc_lifetime_to_expiry(now_msec, preferred_time),