fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-02-16 09:40:35 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

libnm/device-p2p-wifi: cleanup peers handling

Browse source 
Don't reallocate peers-array nor set it to %NULL. Instead,
just emit the signal for the peers and take them out one-by-one.

I am slightly surprised, that the peers array does not need to hold
a reference on the NMP2PPeer instances. But that seems intentional.
I think, the libnm code here should be significantly reworked, but
that is for another time.

Also, delay clearing the pointers until finalize() method. For
the most part, it shouldn't make a difference. Still avoid having
the instance in a badly defined state during dispose() (which
theoretically could be called multiple times).
This commit is contained in:
Thomas Haller 2019-01-28 11:48:09 +01:00
parent efbcac25b8
commit 41b2d8c6c9
1 changed files with 13 additions and 29 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

42
libnm/nm-device-p2p-wifi.c
View file

@ -171,31 +171,18 @@ nm_device_p2p_wifi_get_peer_by_path (NMDeviceP2PWifi *device,
}
static void
clean_up_peers (NMDeviceP2PWifi *self, gboolean in_dispose)
clean_up_peers (NMDeviceP2PWifi *self)
{
NMDeviceP2PWifiPrivate *priv;
GPtrArray *peers;
int i;
NMDeviceP2PWifiPrivate *priv = NM_DEVICE_P2P_WIFI_GET_PRIVATE (self);
g_return_if_fail (NM_IS_DEVICE_P2P_WIFI (self));
while (priv->peers->len > 0) {
NMP2PPeer *peer;
priv = NM_DEVICE_P2P_WIFI_GET_PRIVATE (self);
peer = priv->peers->pdata[priv->peers->len - 1];
g_ptr_array_remove_index (priv->peers, priv->peers->len - 1);
peers = priv->peers;
if (in_dispose)
priv->peers = NULL;
else {
priv->peers = g_ptr_array_new ();
for (i = 0; i < peers->len; i++) {
NMP2PPeer *peer = NM_P2P_PEER (g_ptr_array_index (peers, i));
g_signal_emit (self, signals[PEER_REMOVED], 0, peer);
}
g_signal_emit (self, signals[PEER_REMOVED], 0, peer);
}
g_ptr_array_unref (peers);
}
static gboolean
@ -392,15 +379,7 @@ init_dbus (NMObject *object)
static void
dispose (GObject *object)
{
NMDeviceP2PWifiPrivate *priv = NM_DEVICE_P2P_WIFI_GET_PRIVATE (object);
if (priv->peers)
clean_up_peers (NM_DEVICE_P2P_WIFI (object), TRUE);
g_clear_object (&priv->proxy);
if (priv->wfd_ies)
g_byte_array_unref (priv->wfd_ies);
priv->wfd_ies = NULL;
clean_up_peers (NM_DEVICE_P2P_WIFI (object));
G_OBJECT_CLASS (nm_device_p2p_wifi_parent_class)->dispose (object);
}
@ -410,7 +389,12 @@ finalize (GObject *object)
{
NMDeviceP2PWifiPrivate *priv = NM_DEVICE_P2P_WIFI_GET_PRIVATE (object);
g_clear_object (&priv->proxy);
g_free (priv->hw_address);
if (priv->wfd_ies)
g_byte_array_unref (priv->wfd_ies);
if (priv->peers)
g_ptr_array_unref (priv->peers);
G_OBJECT_CLASS (nm_device_p2p_wifi_parent_class)->finalize (object);
}