From 41148caba8dc6df6c9025680e53c1c88f048dc73 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Tue, 18 Apr 2017 13:16:54 +0200 Subject: [PATCH] core: enable "log-with-ptr" by default for platform and route-manager Arguably, we currently only have one instance of NMPlatform, NMRouteManager, NMDefaultRouteManager -- the one owned by the NMNetns singleton. Hence, all these instances we create with "log-with-ptr" set explicitly to false. In the future we want to support namespaces, and it will be be common to have multiple instances. For that we have "log-with-ptr" so we are able to disambiguiate the logging. Change the default to TRUE because it makes more sense. It has currently no effect as the default is never used. --- src/nm-default-route-manager.c | 2 +- src/nm-route-manager.c | 2 +- src/platform/nm-platform.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/nm-default-route-manager.c b/src/nm-default-route-manager.c index e7466ecbd3..9ac6d552c0 100644 --- a/src/nm-default-route-manager.c +++ b/src/nm-default-route-manager.c @@ -1549,7 +1549,7 @@ nm_default_route_manager_class_init (NMDefaultRouteManagerClass *klass) obj_properties[PROP_LOG_WITH_PTR] = g_param_spec_boolean (NM_DEFAULT_ROUTE_MANAGER_LOG_WITH_PTR, "", "", - FALSE, + TRUE, G_PARAM_WRITABLE | G_PARAM_CONSTRUCT_ONLY | G_PARAM_STATIC_STRINGS); diff --git a/src/nm-route-manager.c b/src/nm-route-manager.c index 0b66cf275a..b58cdeb069 100644 --- a/src/nm-route-manager.c +++ b/src/nm-route-manager.c @@ -1297,7 +1297,7 @@ nm_route_manager_class_init (NMRouteManagerClass *klass) obj_properties[PROP_LOG_WITH_PTR] = g_param_spec_boolean (NM_ROUTE_MANAGER_LOG_WITH_PTR, "", "", - FALSE, + TRUE, G_PARAM_WRITABLE | G_PARAM_CONSTRUCT_ONLY | G_PARAM_STATIC_STRINGS); diff --git a/src/platform/nm-platform.c b/src/platform/nm-platform.c index f54a27e002..334b94d411 100644 --- a/src/platform/nm-platform.c +++ b/src/platform/nm-platform.c @@ -4645,7 +4645,7 @@ nm_platform_class_init (NMPlatformClass *platform_class) g_object_class_install_property (object_class, PROP_LOG_WITH_PTR, g_param_spec_boolean (NM_PLATFORM_LOG_WITH_PTR, "", "", - FALSE, + TRUE, G_PARAM_WRITABLE | G_PARAM_CONSTRUCT_ONLY | G_PARAM_STATIC_STRINGS));