From 403f207fe58538f0228ac42918f23d2e6a18e8b6 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Fri, 31 May 2019 15:49:20 +0200 Subject: [PATCH] cli: fix resetting default value for GObject property This matters for properties that don't have 0/NULL/FALSE as default value and when setting an empty property with $ nmcli connection modify "$PROFILE" setting.property '' Fixes: 3c82db710f50 ('cli: reset default value of properties via set_fcn()') --- clients/common/nm-meta-setting-desc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clients/common/nm-meta-setting-desc.c b/clients/common/nm-meta-setting-desc.c index b4cfcb40e0..c252832d35 100644 --- a/clients/common/nm-meta-setting-desc.c +++ b/clients/common/nm-meta-setting-desc.c @@ -762,7 +762,7 @@ _gobject_property_reset (NMSetting *setting, g_value_init (&v, pspec->value_type); if (reset_default) - g_param_value_defaults (pspec, &v); + g_param_value_set_default (pspec, &v); g_object_set_property (G_OBJECT (setting), prop_name, &v); return TRUE; }