ndisc: fix iterating arrays in calc_pre_expiry_rs_msec()

Fixes: de6d069dce ('ndisc: send router solicitations before expiry')
This commit is contained in:
Thomas Haller 2022-12-01 16:17:12 +01:00
parent 21887f88fa
commit 3f04778df2
No known key found for this signature in database
GPG key ID: 29C2366E4DFC5728

View file

@ -1624,28 +1624,28 @@ calc_pre_expiry_rs_msec(NMNDisc *ndisc)
_calc_pre_expiry_rs_msec_worker(
&expiry_msec,
priv->last_rs_msec,
nm_g_array_index(rdata->addresses, NMNDiscAddress, 0).expiry_msec);
nm_g_array_index(rdata->addresses, NMNDiscAddress, i).expiry_msec);
}
for (i = 0; i < rdata->routes->len; i++) {
_calc_pre_expiry_rs_msec_worker(
&expiry_msec,
priv->last_rs_msec,
nm_g_array_index(rdata->routes, NMNDiscRoute, 0).expiry_msec);
nm_g_array_index(rdata->routes, NMNDiscRoute, i).expiry_msec);
}
for (i = 0; i < rdata->dns_servers->len; i++) {
_calc_pre_expiry_rs_msec_worker(
&expiry_msec,
priv->last_rs_msec,
nm_g_array_index(rdata->dns_servers, NMNDiscDNSServer, 0).expiry_msec);
nm_g_array_index(rdata->dns_servers, NMNDiscDNSServer, i).expiry_msec);
}
for (i = 0; i < rdata->dns_domains->len; i++) {
_calc_pre_expiry_rs_msec_worker(
&expiry_msec,
priv->last_rs_msec,
nm_g_array_index(rdata->dns_domains, NMNDiscDNSDomain, 0).expiry_msec);
nm_g_array_index(rdata->dns_domains, NMNDiscDNSDomain, i).expiry_msec);
}
return expiry_msec - solicit_retransmit_time_jitter(NM_NDISC_PRE_EXPIRY_TIME_MSEC);