From 3ebeb43c5f54939405ab1fdb62cc8d1a21cdb8d5 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Fri, 2 Aug 2019 17:45:49 +0200 Subject: [PATCH] libnm: remove dead code in nm_team_setting_config_get() I was aware that this code is not reachable. But for consistency, it seems better to be explict about it (to avoid future bugs when refactoring). Anyway, Coverity complains about it. So assert instead. (cherry picked from commit 643bc4ca2275ed00ed6607d2b308f65d531675b8) --- libnm-core/nm-team-utils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libnm-core/nm-team-utils.c b/libnm-core/nm-team-utils.c index ac834d7408..63018b09f7 100644 --- a/libnm-core/nm-team-utils.c +++ b/libnm-core/nm-team-utils.c @@ -1587,8 +1587,8 @@ nm_team_setting_config_get (const NMTeamSetting *self) || _team_setting_has_fields_any_v (self, attr_lst_runner_pt3, G_N_ELEMENTS (attr_lst_runner_pt3))) { gboolean list_is_empty2 = TRUE; - if (!list_is_empty) - nm_json_aux_gstr_append_delimiter (gstr); + nm_assert (list_is_empty); + nm_json_aux_gstr_append_obj_name (gstr, "runner", '{'); if (_team_setting_fields_to_json_maybe (self, gstr, !list_is_empty2, attr_lst_runner_pt1, G_N_ELEMENTS (attr_lst_runner_pt1)))