From 3e869c107da3a8d9ac29954463b8200f63a9f353 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Thu, 19 Mar 2020 14:45:09 +0100 Subject: [PATCH] cli: fix use after free in wifi_list_finish() Fixes: db396cea9d37 ('cli: rework do_device_wifi_list() to scan and print Wi-Fi list') --- clients/cli/devices.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/clients/cli/devices.c b/clients/cli/devices.c index 77eb32f07f..01ffb02f9c 100644 --- a/clients/cli/devices.c +++ b/clients/cli/devices.c @@ -2938,7 +2938,7 @@ wifi_list_finish (WifiListData *wifi_list_data, for (i = 0; scan_info->devices[i]; i++) { wifi_print_aps (NM_DEVICE_WIFI (scan_info->devices[i]), - scan_info->nmc, + nmc, scan_info->out_indices, scan_info->tmpl, scan_info->bssid_user, @@ -2958,7 +2958,7 @@ wifi_list_finish (WifiListData *wifi_list_data, g_array_unref (scan_info->out_indices); nm_g_slice_free (scan_info); - scan_info->nmc->should_wait--; + nmc->should_wait--; g_main_loop_quit (loop); }