fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-05-05 01:47:58 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

core/trivial: add code comment about using GChildWatchSource

Browse source
This commit is contained in:
Thomas Haller 2023-03-28 18:09:35 +02:00
parent 597e127bcb
commit 346196792c
No known key found for this signature in database
GPG key ID: 29C2366E4DFC5728
1 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/core/nm-core-utils.c
View file

@ -5144,6 +5144,18 @@ nm_utils_spawn_helper(const char *const *args,
* main context. */
nm_assert(context == g_main_context_default());
/* We are using a GChildWatchSource in combination with kill()/waitpid()
* (where helper_info_free() clears the source and calls
* nm_utils_kill_child_async()). That leads to races where glib might have
* already reaped the process and our waitpid() call fails with:
*
* <error> [TIMESTAMP] kill child process 'nm-daemon-helper' (PID): failed due to unexpected return value -1 by waitpid (No child processes, 10) after sending SIGKILL (9)
*
* This is a bug in glib, addressed by [1]. Maybe there should be a
* workaround here, and not using the child watcher?
*
* [1] https://gitlab.gnome.org/GNOME/glib/-/merge_requests/3353
*/
info->child_watch_source = nm_g_child_watch_source_new(info->pid,
G_PRIORITY_DEFAULT,
helper_child_terminated,