From 33cb2f3723554b177803945d709d911cf6a3c77e Mon Sep 17 00:00:00 2001 From: Beniamino Galvani Date: Thu, 26 Oct 2017 08:50:44 +0200 Subject: [PATCH] settings: keep connection alive in delete_auth_cb() Before commit 3ecb57fdc468 ("settings: get rid of callback arguments for nm_settings_connection_delete()") audit logging was done in the callback, which was run by nm_settings_connection_delete() with a reference to the connection to keep it alive. Now we have to keep an extra reference to ensure it doesn't go away. Fixes: 3ecb57fdc46833f2377fa86e045cd0f8461eaab9 --- src/settings/nm-settings-connection.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/settings/nm-settings-connection.c b/src/settings/nm-settings-connection.c index 8dec0bde32..3a3f9ba151 100644 --- a/src/settings/nm-settings-connection.c +++ b/src/settings/nm-settings-connection.c @@ -1884,8 +1884,11 @@ delete_auth_cb (NMSettingsConnection *self, GError *error, gpointer data) { + gs_unref_object NMSettingsConnection *self_keep_alive = NULL; gs_free_error GError *local = NULL; + self_keep_alive = g_object_ref (self); + if (error) { nm_audit_log_connection_op (NM_AUDIT_OP_CONN_DELETE, self, FALSE, NULL, subject, error->message);