From 30a6742d96db364862e21e7262f40fbff3aa92b3 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Mon, 22 May 2023 09:16:10 +0200 Subject: [PATCH] cli: fix offline mode for parsing "connection.secondaries" $ nmcli --offline connection add type ethernet con-name x connection.secondaries foo (process:48855): nm-CRITICAL **: 09:16:03.051: nm_client_get_connections: assertion 'NM_IS_CLIENT(client)' failed ** nm:ERROR:src/nmcli/common.c:437:nmc_find_connection: assertion failed: (connections) Bail out! nm:ERROR:src/nmcli/common.c:437:nmc_find_connection: assertion failed: (connections) Aborted (core dumped) --- src/nmcli/settings.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/nmcli/settings.c b/src/nmcli/settings.c index 3c1f3c38ff..e637bc53b1 100644 --- a/src/nmcli/settings.c +++ b/src/nmcli/settings.c @@ -366,6 +366,9 @@ _set_fcn_precheck_connection_secondaries(NMClient *client, if (!strv0) return TRUE; + if (!client) + return TRUE; + connections = nm_client_get_connections(client); strv = g_strdupv((char **) strv0);