fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-01-03 12:50:17 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

wwan/modem: return early if set_mm_enable is not implemented

Browse source 
We don't want to e.g. pre-empt the state change signal, because it's not
gonna happen.
This commit is contained in:
Ratchanan Srirattanamet 2022-10-14 22:11:24 +07:00 • committed by Thomas Haller
parent 580453d376
commit 2f3a0eaa0b
No known key found for this signature in database
GPG key ID: 29C2366E4DFC5728
1 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/core/devices/wwan/nm-modem.c
View file

@ -353,6 +353,12 @@ nm_modem_set_mm_enabled(NMModem *self, gboolean enabled)
NMModemPrivate *priv = NM_MODEM_GET_PRIVATE(self);
NMModemState prev_state = priv->state;
/* Not all modem classes support set_mm_enabled */
if (!NM_MODEM_GET_CLASS(self)->set_mm_enabled) {
_LOGD("cannot enable modem: not implemented");
return;
}
if (enabled && priv->state >= NM_MODEM_STATE_ENABLING) {
_LOGD("cannot enable modem: already enabled");
return;
@ -375,9 +381,7 @@ nm_modem_set_mm_enabled(NMModem *self, gboolean enabled)
return;
}
/* Not all modem classes support set_mm_enabled */
if (NM_MODEM_GET_CLASS(self)->set_mm_enabled)
NM_MODEM_GET_CLASS(self)->set_mm_enabled(self, enabled);
NM_MODEM_GET_CLASS(self)->set_mm_enabled(self, enabled);
/* Pre-empt the state change signal */
nm_modem_set_state(self,