From 2ecc7e8cb5b4169378a68e085db2527c4ef82cdf Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Fri, 2 Aug 2019 09:24:01 +0200 Subject: [PATCH] initrd: avoid coverity warning in parse_ip() about "Dereference before null check" get_word() only moves the "argument" pointer forward. It never sets it to %NULL. Also, above we already dereference argument, so Coverity thinks that this NULL check indicates a bug. Drop it to silence Coverity. (cherry picked from commit 4596d7793cee22228e68d102fa199ed1736a2050) --- src/initrd/nmi-cmdline-reader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/initrd/nmi-cmdline-reader.c b/src/initrd/nmi-cmdline-reader.c index ccdd1f2992..7a3af8d661 100644 --- a/src/initrd/nmi-cmdline-reader.c +++ b/src/initrd/nmi-cmdline-reader.c @@ -244,7 +244,7 @@ parse_ip (GHashTable *connections, const char *sysfs_dir, char *argument) dns[0] = tmp; dns[1] = get_word (&argument, ':'); dns_addr_family[1] = guess_ip_address_family (dns[1]); - if (argument && *argument) + if (*argument) _LOGW (LOGD_CORE, "Ignoring extra: '%s'.", argument); } else { mtu = tmp;