fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-01-08 02:30:18 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

loopback: reject setting "slave-type"/"master" for "loopback" profiles

Browse source 
A loopback interface cannot be attached to a controller interface (in kernel).

Also, we have special handling for the loopback address 127.0.0.1. It's
not clear how that should behave when the loopback device would be
attached to another interface.

Just reject such configuration as invalid.

Fixes: e8618f03d7 ('support loopback interface')
This commit is contained in:
Thomas Haller 2022-12-01 13:11:59 +01:00
parent a14d65d06f
commit 2eca11bcba
No known key found for this signature in database
GPG key ID: 29C2366E4DFC5728
1 changed files with 21 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
src/libnm-core-impl/nm-setting-loopback.c
View file

@ -70,9 +70,10 @@ static gboolean
verify(NMSetting *setting, NMConnection *connection, GError **error)
{
if (connection) {
NMSettingIPConfig *s_ip4;
NMSettingIPConfig *s_ip6;
const char *method;
NMSettingIPConfig *s_ip4;
NMSettingIPConfig *s_ip6;
NMSettingConnection *s_con;
const char *method;
if ((s_ip4 = nm_connection_get_setting_ip4_config(connection))) {
if ((method = nm_setting_ip_config_get_method(s_ip4))
@ -122,6 +123,23 @@ verify(NMSetting *setting, NMConnection *connection, GError **error)
return FALSE;
}
}
if ((s_con = nm_connection_get_setting_connection(connection))) {
if (nm_setting_connection_get_slave_type(s_con)
|| nm_setting_connection_get_master(s_con)) {
g_set_error(error,
NM_CONNECTION_ERROR,
NM_CONNECTION_ERROR_INVALID_PROPERTY,
_("a loopback profile cannot be a port"));
g_prefix_error(error,
"%s.%s: ",
NM_SETTING_CONNECTION_SETTING_NAME,
nm_setting_connection_get_slave_type(s_con)
? NM_SETTING_CONNECTION_SLAVE_TYPE
: NM_SETTING_CONNECTION_MASTER);
return FALSE;
}
}
}
return TRUE;
}