From 2e966436d8df9e23a979ec3077cd4b7f60c3e2db Mon Sep 17 00:00:00 2001
From: Beniamino Galvani <bgalvani@redhat.com>
Date: Thu, 22 Dec 2022 11:23:46 +0100
Subject: [PATCH] nmcli: fix double free

 src/nmcli/devices.c:1196: double_free: Calling "_nm_auto_strfreev" frees pointer "arg_arr" which has already been freed.

Fixes: c5d45848dd07 ('cli: mark argv argument for command line parsing as const')
(cherry picked from commit a39ec8ca75eee38fcef18b5e3f1e5e61128f82ba)
---
 src/nmcli/devices.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/src/nmcli/devices.c b/src/nmcli/devices.c
index 9b7ebce39b..db14ec05ae 100644
--- a/src/nmcli/devices.c
+++ b/src/nmcli/devices.c
@@ -1149,7 +1149,7 @@ get_device_list(NmCli *nmc, int *argc, const char *const **argv)
     if (*argc == 0) {
         g_string_printf(nmc->return_text, _("Error: No interface specified."));
         nmc->return_value = NMC_RESULT_ERROR_USER_INPUT;
-        goto error;
+        return NULL;
     }
 
     devices = nmc_get_devices_sorted(nmc->client);
@@ -1190,9 +1190,6 @@ get_device_list(NmCli *nmc, int *argc, const char *const **argv)
     }
     g_free(devices);
 
-error:
-    g_strfreev(arg_arr);
-
     return queue;
 }