From 2cb3c7e8a0164219dcbdc06a4fe073527bb23b7b Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Mon, 22 Dec 2014 18:01:12 +0100 Subject: [PATCH] platform: route_search_cache() should not treat a metric 0 as "any" route This match-any behavior ignoring metric is nowhere used. And even if we would need such a behavior, using 0 is wrong because IPv4 routes can have a metric of zero. --- src/platform/nm-linux-platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/platform/nm-linux-platform.c b/src/platform/nm-linux-platform.c index 0cf743b453..d59b55bc1f 100644 --- a/src/platform/nm-linux-platform.c +++ b/src/platform/nm-linux-platform.c @@ -3865,7 +3865,7 @@ route_search_cache (struct nl_cache *cache, int family, int ifindex, const void if (!_route_match (rtnlroute, family, ifindex, FALSE)) continue; - if (metric && metric != rtnl_route_get_priority (rtnlroute)) + if (metric != rtnl_route_get_priority (rtnlroute)) continue; dst = rtnl_route_get_dst (rtnlroute);