From 2b6145cc8f3d9b6509aa13a1b0918a4fbfedc20e Mon Sep 17 00:00:00 2001 From: Fernando Fernandez Mancera Date: Wed, 15 May 2024 11:48:08 +0200 Subject: [PATCH] libnm-glib-aux: fix gcc warning maybe-uninitialized This is breaking compilation when using LTO. ``` src/libnm-glib-aux/nm-uuid.c: In function 'nm_uuid_generate_from_strings_strv': src/libnm-glib-aux/nm-uuid.c:490:12: error: '_1' may be used uninitialized [-Werror=maybe-uninitialized] 490 | return nm_uuid_generate_from_string_str(s, slen, uuid_type, type_args); | ^ src/libnm-glib-aux/nm-uuid.c:392:1: note: by argument 1 of type 'const char *' to 'nm_uuid_generate_from_string_str' declared here 392 | nm_uuid_generate_from_string_str(const char *s, | ^ lto1: all warnings being treated as errors lto-wrapper: fatal error: gcc returned 1 exit status compilation terminated. ``` --- src/libnm-glib-aux/nm-uuid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libnm-glib-aux/nm-uuid.c b/src/libnm-glib-aux/nm-uuid.c index e39d2ea563..154b483070 100644 --- a/src/libnm-glib-aux/nm-uuid.c +++ b/src/libnm-glib-aux/nm-uuid.c @@ -433,7 +433,7 @@ nm_uuid_generate_from_strings_strv(NMUuidType uuid_type, { nm_auto_str_buf NMStrBuf str = NM_STR_BUF_INIT_A(NM_UTILS_GET_NEXT_REALLOC_SIZE_232, TRUE); gsize slen; - const char *s; + const char *s = NULL; if (len > 0) { gboolean has_nulls = FALSE;