fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-05-01 03:18:06 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

logging: prefer stack buffer for logging message

Browse source
This commit is contained in:
Thomas Haller 2021-01-14 11:43:56 +01:00
parent 45ba49f322
commit 29e93b1738
No known key found for this signature in database
GPG key ID: 29C2366E4DFC5728
1 changed files with 4 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/libnm-log-core/nm-logging.c
View file

@ -656,8 +656,9 @@ _nm_log_impl(const char *file,
const char *fmt,
...)
{
va_list args;
char * msg;
char msg_stack[400];
gs_free char * msg_heap = NULL;
const char * msg;
GTimeVal tv;
int errsv;
const NMLogDomain *cur_log_state;
@ -698,9 +699,7 @@ _nm_log_impl(const char *file,
errno = error;
}
va_start(args, fmt);
msg = g_strdup_vprintf(fmt, args);
va_end(args);
msg = nm_vsprintf_buf_or_alloc(fmt, fmt, msg_stack, &msg_heap, NULL);
#define MESSAGE_FMT "%s%-7s [%ld.%04ld] %s"
#define MESSAGE_ARG(prefix, tv, msg) \
@ -797,8 +796,6 @@ _nm_log_impl(const char *file,
break;
}
g_free(msg);
errno = errsv;
}