diff --git a/src/nm-device-802-3-ethernet.c b/src/nm-device-802-3-ethernet.c index db2cd87157..31b8c8d0a5 100644 --- a/src/nm-device-802-3-ethernet.c +++ b/src/nm-device-802-3-ethernet.c @@ -29,6 +29,9 @@ #include #include #include +#include +#include +#include #include "nm-device-802-3-ethernet.h" #include "nm-device-interface.h" @@ -344,10 +347,10 @@ nm_device_802_3_ethernet_get_speed (NMDevice8023Ethernet *self) { int fd; struct ifreq ifr; - struct ethtool_cmd edata; - const char *iface; + struct ethtool_cmd edata = { + .cmd = ETHTOOL_GSET, + }; guint32 speed = 0; - size_t len; g_return_val_if_fail (self != NULL, 0); @@ -357,13 +360,10 @@ nm_device_802_3_ethernet_get_speed (NMDevice8023Ethernet *self) return 0; } - iface = nm_device_get_iface (NM_DEVICE (self)); - len = MIN (sizeof (ifr.ifr_name) - 1, strlen (iface)); memset (&ifr, 0, sizeof (struct ifreq)); - strncpy (ifr.ifr_name, iface, len); - - edata.cmd = ETHTOOL_GSET; + strncpy (ifr.ifr_name, nm_device_get_iface (NM_DEVICE (self)), IFNAMSIZ); ifr.ifr_data = (char *) &edata; + if (ioctl (fd, SIOCETHTOOL, &ifr) == -1) goto out; @@ -380,8 +380,6 @@ real_set_hw_address (NMDevice *dev) NMDevice8023Ethernet *self = NM_DEVICE_802_3_ETHERNET (dev); struct ifreq req; int ret, fd; - const char *iface; - size_t len; fd = socket (PF_INET, SOCK_DGRAM, 0); if (fd < 0) { @@ -389,10 +387,8 @@ real_set_hw_address (NMDevice *dev) return; } - iface = nm_device_get_iface (dev); - len = MIN (sizeof (req.ifr_name) - 1, strlen (iface)); memset (&req, 0, sizeof (struct ifreq)); - strncpy (req.ifr_name, iface, len); + strncpy (req.ifr_name, nm_device_get_iface (dev), IFNAMSIZ); ret = ioctl (fd, SIOCGIFHWADDR, &req); if (ret == 0) { @@ -826,8 +822,6 @@ supports_ethtool_carrier_detect (NMDevice8023Ethernet *self) struct ifreq ifr; gboolean supports_ethtool = FALSE; struct ethtool_cmd edata; - const char *iface; - size_t len; g_return_val_if_fail (self != NULL, FALSE); @@ -837,10 +831,8 @@ supports_ethtool_carrier_detect (NMDevice8023Ethernet *self) return FALSE; } - iface = nm_device_get_iface (NM_DEVICE (self)); - len = MIN (sizeof (ifr.ifr_name) - 1, strlen (iface)); memset (&ifr, 0, sizeof (struct ifreq)); - strncpy (ifr.ifr_name, iface, len); + strncpy (ifr.ifr_name, nm_device_get_iface (NM_DEVICE (self)), IFNAMSIZ); edata.cmd = ETHTOOL_GLINK; ifr.ifr_data = (char *) &edata; @@ -890,8 +882,6 @@ supports_mii_carrier_detect (NMDevice8023Ethernet *self) int err, fd, bmsr; struct ifreq ifr; gboolean supports_mii = FALSE; - const char *iface; - size_t len; g_return_val_if_fail (self != NULL, FALSE); @@ -901,10 +891,8 @@ supports_mii_carrier_detect (NMDevice8023Ethernet *self) return 0; } - iface = nm_device_get_iface (NM_DEVICE (self)); - len = MIN (sizeof (ifr.ifr_name) - 1, strlen (iface)); memset (&ifr, 0, sizeof (struct ifreq)); - strncpy (ifr.ifr_name, iface, len); + strncpy (ifr.ifr_name, nm_device_get_iface (NM_DEVICE (self)), IFNAMSIZ); err = ioctl (fd, SIOCGMIIPHY, &ifr); if (err < 0) diff --git a/src/nm-device.c b/src/nm-device.c index 59df3fef9e..647258b7c2 100644 --- a/src/nm-device.c +++ b/src/nm-device.c @@ -25,6 +25,10 @@ #include #include #include +#include +#include +#include +#include #include "nm-device-interface.h" #include "nm-device.h" @@ -194,7 +198,6 @@ real_is_up (NMDevice *self) struct ifreq ifr; const char *iface; int err, fd; - size_t len; fd = socket (PF_INET, SOCK_DGRAM, 0); if (fd < 0) { @@ -204,9 +207,7 @@ real_is_up (NMDevice *self) /* Get device's flags */ iface = nm_device_get_iface (self); - len = MIN (sizeof (ifr.ifr_name) - 1, strlen (iface)); - strncpy (ifr.ifr_name, iface, len); - + strncpy (ifr.ifr_name, iface, IFNAMSIZ); err = ioctl (fd, SIOCGIFFLAGS, &ifr); close (fd); @@ -1472,10 +1473,8 @@ void nm_device_update_ip4_address (NMDevice *self) { struct ifreq req; - const char *iface; guint32 new_address; int fd, err; - size_t len; g_return_if_fail (self != NULL); @@ -1485,15 +1484,11 @@ nm_device_update_ip4_address (NMDevice *self) return; } - iface = nm_device_get_iface (self); - len = MIN (sizeof (req.ifr_name) - 1, strlen (iface)); - memset (&req, 0, sizeof (struct ifreq)); - strncpy (req.ifr_name, iface, len); - + strncpy (req.ifr_name, nm_device_get_iface (self), IFNAMSIZ); err = ioctl (fd, SIOCGIFADDR, &req); - close (fd); + if (err != 0) return;