fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-06-19 12:28:29 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

settings/trivial: add code comments

Browse source
This commit is contained in:
Thomas Haller 2018-03-29 10:50:34 +02:00
parent f41279ca1d
commit 24c3eacac6
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/settings/plugins/ifcfg-rh/nms-ifcfg-rh-plugin.c
View file

@ -326,7 +326,10 @@ update_connection (SettingsPluginIfcfg *self,
if (new_unmanaged || new_unrecognized) {
if (!old_unmanaged && !old_unrecognized) {
/* ref connection first, because we put it into priv->connections below.
* Emitting signal-removed might otherwise delete it. */
g_object_ref (connection_by_uuid);
/* Unexport the connection by telling the settings service it's
* been removed.
*/
@ -340,7 +343,7 @@ update_connection (SettingsPluginIfcfg *self,
*/
g_hash_table_insert (priv->connections,
g_strdup (nm_connection_get_uuid (NM_CONNECTION (connection_by_uuid))),
connection_by_uuid);
connection_by_uuid/*<< took reference above*/);
}
} else {
if (old_unmanaged /* && !new_unmanaged */) {
@ -372,7 +375,9 @@ update_connection (SettingsPluginIfcfg *self,
_LOGI ("add connection "NM_IFCFG_CONNECTION_LOG_FMT, NM_IFCFG_CONNECTION_LOG_ARG (connection_new));
else
_LOGI ("new connection "NM_IFCFG_CONNECTION_LOG_FMT, NM_IFCFG_CONNECTION_LOG_ARG (connection_new));
g_hash_table_insert (priv->connections, g_strdup (uuid), connection_new);
g_hash_table_insert (priv->connections,
g_strdup (uuid),
connection_new /* take reference */);
g_signal_connect (connection_new, NM_SETTINGS_CONNECTION_REMOVED,
G_CALLBACK (connection_removed_cb),