From 24a7f88bc56b66745c1e6b9444df8a80125de059 Mon Sep 17 00:00:00 2001 From: Beniamino Galvani Date: Wed, 4 Oct 2017 14:30:57 +0200 Subject: [PATCH] device: fix frozen notify signals on unrealize error path If unrealize() failed we returned without thawing notify signals. Fix this by moving g_object_freeze_notify() after the unrealization/deletion but before the properties are reset in unrealize_notify(). Fixes: a93807c288743f499362f7edfe0674020762811c --- src/devices/nm-device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/devices/nm-device.c b/src/devices/nm-device.c index cf73ee016a..435eeee2d7 100644 --- a/src/devices/nm-device.c +++ b/src/devices/nm-device.c @@ -3431,7 +3431,6 @@ nm_device_unrealize (NMDevice *self, gboolean remove_resources, GError **error) g_return_val_if_fail (priv->iface != NULL, FALSE); g_return_val_if_fail (priv->real, FALSE); - g_object_freeze_notify (G_OBJECT (self)); ifindex = nm_device_get_ifindex (self); @@ -3448,6 +3447,7 @@ nm_device_unrealize (NMDevice *self, gboolean remove_resources, GError **error) } } + g_object_freeze_notify (G_OBJECT (self)); NM_DEVICE_GET_CLASS (self)->unrealize_notify (self); _parent_set_ifindex (self, 0, FALSE);