2006-01-11 Robert Love <rml@novell.com>

* src/nm-device-802-3-ethernet.c: Use the if_mii() inline function that
	  is defined in <linux/mii.h> to return the mii_ioctl_data structure
	  from the ifreq structure in lieu of an open coded solution.  Removes
	  a life-threatening type-punning.
	* configure.in: Remove '-Wno-strict-aliasing' as we no longer pun any
	  types, ever, whatsoever, baby.


git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1316 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
This commit is contained in:
Robert Love 2006-01-11 20:07:56 +00:00 committed by Robert Love
parent 9a680fdef1
commit 24a2f51a1f
4 changed files with 31 additions and 19 deletions

View file

@ -1,3 +1,12 @@
2006-01-11 Robert Love <rml@novell.com>
* src/nm-device-802-3-ethernet.c: Use the if_mii() inline function that
is defined in <linux/mii.h> to return the mii_ioctl_data structure
from the ifreq structure in lieu of an open coded solution. Removes
a life-threatening type-punning.
* configure.in: Remove '-Wno-strict-aliasing' as we no longer pun any
types, ever, whatsoever, baby.
2006-01-11 Robert Love <rml@novell.com>
* gnome/applet/applet-dbus-devices.c, gnome/applet/applet-dbus.c,
@ -64,13 +73,15 @@
* libnm-util/dbus-helpers.c
libnm-util/dbus-helpers.h
- (nmu_create_dbus_error_message): rename parameter 'namespace'
to 'exception_namespace' (:namespace is a keyword in C++)
to 'exception_namespace' (:namespace is a keyword in
C++)
2006-01-09 Dan Williams <dcbw@redhat.com>
* src/NetworkManagerPolicy.c
- (nm_policy_device_change_check): don't autoswitch away from
Ad-Hoc networks, since there's really no concept of "link"
Ad-Hoc networks, since there's really no concept of
"link"
* src/nm-dbus-nm.c
- (nm_dbus_nm_create_wireless_network): mark created networks
@ -147,7 +158,7 @@
- Change existing wpa-psk stuff to wpa-psk-hex
- Add new widgets for wpa-psk-passphrase
* gnome/applet/wireless-security-manager.c
* gnome/applet/wireless-security-manager.c
- (wsm_set_capabilities): enable WPA options
* gnome/applet/wso-wpa-psk-passphrase.c
@ -184,15 +195,16 @@
2006-01-07 Dan Williams <dcbw@redhat.com>
* src/NetworkManagerUtils.c
- (nm_utils_supplicant_request, nm_utils_supplicant_request_with_check):
- (nm_utils_supplicant_request,
nm_utils_supplicant_request_with_check):
pass correct buffer length to wpa_ctrl_request()
2006-01-07 Dan Williams <dcbw@redhat.com>
* src/nm-device-private.h
src/nm-device.c
- (nm_device_activate_schedule_stage3_ip_config_start): make this
function available to subclasses
- (nm_device_activate_schedule_stage3_ip_config_start): make
this function available to subclasses
2006-01-06 Robert Love <rml@novell.com>

View file

@ -260,9 +260,9 @@ if test "$GCC" = "yes" -a "$set_more_warnings" != "no"; then
AC_MSG_RESULT(yes)
CFLAGS="-Wall -Werror -std=gnu89 $CFLAGS"
for option in -Wno-unused -Wno-sign-compare -Wno-strict-aliasing \
for option in -Wno-unused -Wno-sign-compare -Wmissing-declarations \
-Wdeclaration-after-statement -Wstrict-prototypes \
-Wmissing-prototypes -Wmissing-declarations; do
-Wmissing-prototypes; do
SAVE_CFLAGS="$CFLAGS"
CFLAGS="$CFLAGS $option"
AC_MSG_CHECKING([whether gcc understands $option])

View file

@ -375,7 +375,7 @@ mdio_read (NMDevice8023Ethernet *self, NMSock *sk, struct ifreq *ifr, int locati
iface = nm_device_get_iface (NM_DEVICE (self));
mii = (struct mii_ioctl_data *) &(ifr->ifr_data);
mii = if_mii (ifr);
mii->reg_num = location;
#ifdef IOCTL_DEBUG

View file

@ -106,7 +106,7 @@ static void print_string (const char *label, const char *data)
spaces[i] = 0x20;
spaces[i] = 0x00;
fprintf (stdout, " %s:%s%s\n", label, &spaces[0], data);
printf (" %s:%s%s\n", label, &spaces[0], data);
}
@ -256,7 +256,7 @@ static void detail_device (DBusConnection *connection, const char *path)
DBUS_TYPE_ARRAY, DBUS_TYPE_STRING, &networks, &num_networks,
DBUS_TYPE_INVALID))
{
fprintf (stdout, "- Device: %s ----------------------------------------------------------------\n", iface);
printf ("- Device: %s ----------------------------------------------------------------\n", iface);
/* General information */
print_string ("NM Path", op);
@ -286,7 +286,7 @@ static void detail_device (DBusConnection *connection, const char *path)
char *str_strength;
int i;
fprintf (stdout, "\n Wireless Settings\n");
printf ("\n Wireless Settings\n");
if (caps & NM_DEVICE_CAP_WIRELESS_SCAN)
print_string (" Scanning", "yes");
@ -299,7 +299,7 @@ static void detail_device (DBusConnection *connection, const char *path)
print_string (" WPA2 Encryption", "yes");
/*
fprintf (stdout, "\n Wireless Settings\n");
printf ("\n Wireless Settings\n");
if (mode == IW_MODE_INFRA)
print_string (" Mode", "Infrastructure");
else if (mode == IW_MODE_ADHOC)
@ -309,13 +309,13 @@ static void detail_device (DBusConnection *connection, const char *path)
g_free (str_strength);
*/
fprintf (stdout, "\n Wireless Networks (* = Current Network)\n");
printf ("\n Wireless Networks (* = Current Network)\n");
for (i = 0; i < num_networks; i++)
detail_network (connection, networks[i], active_network_path);
}
else if (type == DEVICE_TYPE_802_3_ETHERNET)
{
fprintf (stdout, "\n Wired Settings\n");
printf ("\n Wired Settings\n");
if (link_active)
print_string (" Hardware Link", "yes");
else
@ -325,7 +325,7 @@ static void detail_device (DBusConnection *connection, const char *path)
/* IP Setup info */
if (active)
{
fprintf (stdout, "\n IP Settings:\n");
printf ("\n IP Settings:\n");
print_string (" IP Address", ip4_address);
print_string (" Subnet Mask", subnetmask);
print_string (" Broadcast", broadcast);
@ -335,7 +335,7 @@ static void detail_device (DBusConnection *connection, const char *path)
}
fprintf (stdout, "\n\n");
printf ("\n\n");
dbus_free_string_array (networks);
}
else
@ -407,11 +407,11 @@ int main( int argc, char *argv[] )
return 1;
}
fprintf (stdout, "\nNetworkManager Tool\n\n");
printf ("\nNetworkManager Tool\n\n");
if (!get_nm_state (connection))
{
fprintf (stdout, "\n\nNetworkManager appears not to be running (could not get its state).\n");
fprintf (stderr, "\n\nNetworkManager appears not to be running (could not get its state).\n");
exit (1);
}