fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-05-02 17:48:07 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

iwd: Fix the leaks in get_agent_request_network_path

Browse source 
Don't request new copies of strings from g_variant_get() to avoid
leaking memory as pointed out by Thomas Haller.

Fixes: dc0e31fb70 ('iwd: Add the wifi.iwd.autoconnect setting')
(cherry picked from commit 5ccb8ce17a)
This commit is contained in:
Andrew Zaborowski 2021-02-12 11:04:26 +01:00 • committed by Thomas Haller
parent 8f2ca652d9
commit 210d2696a9
No known key found for this signature in database
GPG key ID: 29C2366E4DFC5728
1 changed files with 5 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/core/devices/wifi/nm-device-iwd.c
View file

@ -1282,15 +1282,13 @@ get_agent_request_network_path(GDBusMethodInvocation *invocation)
const char *network_path = NULL;
if (nm_streq(method_name, "RequestPassphrase"))
g_variant_get(params, "(o)", &network_path);
g_variant_get(params, "(&o)", &network_path);
else if (nm_streq(method_name, "RequestPrivateKeyPassphrase"))
g_variant_get(params, "(o)", &network_path);
g_variant_get(params, "(&o)", &network_path);
else if (nm_streq(method_name, "RequestUserNameAndPassword"))
g_variant_get(params, "(o)", &network_path);
else if (nm_streq(method_name, "RequestUserPassword")) {
const char *user;
g_variant_get(params, "(os)", &network_path, &user);
}
g_variant_get(params, "(&o)", &network_path);
else if (nm_streq(method_name, "RequestUserPassword"))
g_variant_get(params, "(&os)", &network_path, NULL);
return network_path;
}