fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-02-09 23:40:33 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

wwan: don't disconnect if nothing to disconnect

Browse source 
Avoid this error:

NetworkManager[25181]: <warn> (cdc-wdm1): Failed to connect 'T-Mobile Internet': Connection requested IPv4 but IPv4 is unsuported by the modem.
NetworkManager[25181]: <info> (cdc-wdm1): device state change: prepare -> failed (reason 'modem-init-failed') [40 120 28]

** (NetworkManager:25181): CRITICAL **: mm_modem_simple_disconnect: assertion 'MM_IS_MODEM_SIMPLE (self)' failed

self->priv->simple_iface is only valid if stage1/prepare actually
completes, so don't try to access it if stage1/prepare failed.
This commit is contained in:
Dan Williams 2014-06-12 15:28:52 -05:00
parent b5817dffa0
commit 20081816e1
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/devices/wwan/nm-modem-broadband.c
View file

@ -866,11 +866,15 @@ simple_disconnect_ready (MMModemSimple *modem_iface,
}
static void
disconnect (NMModem *self,
disconnect (NMModem *modem,
gboolean warn)
{
NMModemBroadband *self = NM_MODEM_BROADBAND (modem);
SimpleDisconnectContext *ctx;
if (!self->priv->simple_iface)
return;
ctx = g_slice_new (SimpleDisconnectContext);
ctx->self = g_object_ref (self);