From 1cedca3e69974b0a3588c67fafd57425bb8c4d5f Mon Sep 17 00:00:00 2001 From: Beniamino Galvani Date: Thu, 19 May 2016 15:01:35 +0200 Subject: [PATCH] cli: remove wrong assertion in check_valid_name() As explained in the function comment, a NULL value for @val is acceptable. Otherwise: $ nmcli connection edit (process:2276): nmcli-CRITICAL **: check_valid_name: assertion 'val' failed Fixes: fb8fe1d8cb452d203c8cf0941c2a82e5903a0c8a (cherry picked from commit 73221a809d80799c09b2c97fd821e362acce75c3) --- clients/cli/connections.c | 1 - 1 file changed, 1 deletion(-) diff --git a/clients/cli/connections.c b/clients/cli/connections.c index 9136d9d6b4..0e9a18ed2d 100644 --- a/clients/cli/connections.c +++ b/clients/cli/connections.c @@ -2916,7 +2916,6 @@ check_valid_name (const char *val, const NameItem *array, const NameItem *array_ GError *tmp_err = NULL; int i; - g_return_val_if_fail (val, NULL); g_return_val_if_fail (array, NULL); /* Create a temporary array that can be used in nmc_string_is_valid() */