From 1b30797bc16c7e0cc2e6c5686e52aa12ef5a5425 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Fri, 2 Aug 2019 17:13:15 +0200 Subject: [PATCH] core: assert for valid arguments in _addresses_sort_cmp() Coverity thinks that the arguments could be %NULL. Add an assertion, hoping to silence coverity. --- src/nm-ip6-config.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/nm-ip6-config.c b/src/nm-ip6-config.c index 1096fb4246..1810d51185 100644 --- a/src/nm-ip6-config.c +++ b/src/nm-ip6-config.c @@ -318,6 +318,9 @@ sort_captured_addresses (const CList *lst_a, const CList *lst_b, gconstpointer u const NMPlatformIP6Address *addr_a = NMP_OBJECT_CAST_IP6_ADDRESS (c_list_entry (lst_a, NMDedupMultiEntry, lst_entries)->obj); const NMPlatformIP6Address *addr_b = NMP_OBJECT_CAST_IP6_ADDRESS (c_list_entry (lst_b, NMDedupMultiEntry, lst_entries)->obj); + nm_assert (addr_a); + nm_assert (addr_b); + return _addresses_sort_cmp (addr_a, addr_b, ((NMSettingIP6ConfigPrivacy) GPOINTER_TO_INT (user_data)) == NM_SETTING_IP6_CONFIG_PRIVACY_PREFER_TEMP_ADDR); }