From 1b0d98ab558b764e439cf924d7708ed204c3390f Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Thu, 5 Jan 2023 11:57:41 +0100 Subject: [PATCH] ndisc/tests: fix reference counting in nm_fake_ndisc_new() This adjusts the change from commit ffbcf0158970 ('test-ndisc-fake: free l3cfg after creating fake-ndisc'). ndisc_new() already correctly handles the reference count of l3cfg via "gs_unref_object". The party that took the wrong reference was nm_fake_ndisc_new(). Fixes: 58287cbcc0c8 ('core: rework IP configuration in NetworkManager using layer 3 configuration') (cherry picked from commit da371f81083293f774add7fe78a1153cc78b1675) --- src/core/ndisc/nm-fake-ndisc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/ndisc/nm-fake-ndisc.c b/src/core/ndisc/nm-fake-ndisc.c index 5aea273e24..59bf0c1b74 100644 --- a/src/core/ndisc/nm-fake-ndisc.c +++ b/src/core/ndisc/nm-fake-ndisc.c @@ -358,7 +358,7 @@ NMNDisc * nm_fake_ndisc_new(NML3Cfg *l3cfg) { const NMNDiscConfig config = { - .l3cfg = g_object_ref(NM_L3CFG(l3cfg)), + .l3cfg = NM_L3CFG(l3cfg), .ifname = nm_l3cfg_get_ifname(l3cfg, TRUE), .node_type = NM_NDISC_NODE_TYPE_HOST, .stable_type = NM_UTILS_STABLE_TYPE_UUID,