diff --git a/clients/cli/common.c b/clients/cli/common.c index 1020201731..04ccf8dc1f 100644 --- a/clients/cli/common.c +++ b/clients/cli/common.c @@ -1296,8 +1296,7 @@ nmc_do_cmd (NmCli *nmc, const NMCCommand cmds[], const char *cmd, int argc, char const NMCCommand *c; gs_unref_object GTask *task = NULL; - task = g_task_new (NULL, NULL, command_done, nmc); - g_task_set_source_tag (task, nmc_do_cmd); + task = nm_g_task_new (NULL, NULL, nmc_do_cmd, command_done, nmc); g_task_set_task_data (task, nmc, NULL); if (argc == 0 && nmc->complete) { diff --git a/introspection/org.freedesktop.NetworkManager.Settings.xml b/introspection/org.freedesktop.NetworkManager.Settings.xml index f7be2717b8..0587db5f45 100644 --- a/introspection/org.freedesktop.NetworkManager.Settings.xml +++ b/introspection/org.freedesktop.NetworkManager.Settings.xml @@ -102,6 +102,7 @@ LoadConnections: @filenames: Array of paths to on-disk connection profiles in directories monitored by NetworkManager. @status: Success or failure of the operation as a whole. True if NetworkManager at least tried to load the indicated connections, even if it did not succeed. False if an error occurred before trying to load the connections (eg, permission denied). + Note that before 1.20, NetworkManager had a bug and this @status value was wrong. It is better to assume success if the method does not return with a D-Bus error. On top of that, you can look at @failures to know whether any of the requested files failed. @failures: Paths of connection files that could not be loaded. Loads or reloads the indicated connections from disk. You should call this @@ -119,7 +120,7 @@