fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-01-03 17:30:16 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

merge: branch 'jv/fix-qos-mapping'

Browse source 
platform/vlan: fix incorrect type for ingress/egress qos mappings

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2109
This commit is contained in:
Jan Vaclav 2025-01-16 11:09:13 +00:00
commit 191aaf0fb2
2 changed files with 6 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/core/platform/tests/test-link.c
View file

@ -2264,7 +2264,7 @@ test_software_detect_add(const char *testpath, NMLinkType link_type, int test_mo
}
/*****************************************************************************/
/*
static void
_assert_xgress_qos_mappings_impl(int ifindex, gboolean is_ingress_map, int n_entries, int n, ...)
{
@ -2344,8 +2344,7 @@ _assert_vlan_flags(int ifindex, _NMVlanFlags flags)
g_assert(plnk);
g_assert_cmpint(plnk->flags, ==, flags);
}
*/
/*
static void
test_vlan_set_xgress(void)
{
@ -2361,7 +2360,6 @@ test_vlan_set_xgress(void)
ifindex =
nmtstp_assert_wait_for_link(NM_PLATFORM_GET, DEVICE_NAME, NM_LINK_TYPE_VLAN, 100)->ifindex;
g_assert(nm_platform_link_vlan_set_ingress_map(NM_PLATFORM_GET, ifindex, 4, 5));
_assert_ingress_qos_mappings(ifindex, 1, 4, 5);
@ -2392,7 +2390,6 @@ test_vlan_set_xgress(void)
g_assert(nm_platform_link_vlan_set_ingress_map(NM_PLATFORM_GET, ifindex, 9, 4));
_assert_ingress_qos_mappings(ifindex, 3, 0, 5, 3, 8, 4, 5);
g_assert(nm_platform_link_vlan_set_egress_map(NM_PLATFORM_GET, ifindex, 7, 3));
_assert_egress_qos_mappings(ifindex, 1, 7, 3);
@ -2694,7 +2691,7 @@ test_vlan_set_xgress(void)
nmtstp_link_delete(NULL, -1, ifindex, DEVICE_NAME, TRUE);
nmtstp_link_delete(NULL, -1, ifindex_parent, PARENT_NAME, TRUE);
}
*/
/*****************************************************************************/
static void
@ -4108,7 +4105,7 @@ _nmtstp_setup_tests(void)
test_software_detect_add("/link/software/detect/wireguard/1", NM_LINK_TYPE_WIREGUARD, 1);
test_software_detect_add("/link/software/detect/wireguard/2", NM_LINK_TYPE_WIREGUARD, 2);
// g_test_add_func("/link/software/vlan/set-xgress", test_vlan_set_xgress);
g_test_add_func("/link/software/vlan/set-xgress", test_vlan_set_xgress);
g_test_add_func("/link/set-properties", test_link_set_properties);

4
src/libnm-platform/nm-linux-platform.c
View file

@ -5483,7 +5483,7 @@ _nl_msg_new_link_set_linkinfo_vlan(struct nl_msg *msg,
if (!(qos = nla_nest_start(msg, IFLA_VLAN_INGRESS_QOS)))
goto nla_put_failure;
}
NLA_PUT(msg, i, sizeof(ingress_qos[i]), &ingress_qos[i]);
NLA_PUT(msg, IFLA_VLAN_QOS_MAPPING, sizeof(ingress_qos[i]), &ingress_qos[i]);
}
}
@ -5500,7 +5500,7 @@ _nl_msg_new_link_set_linkinfo_vlan(struct nl_msg *msg,
if (!(qos = nla_nest_start(msg, IFLA_VLAN_EGRESS_QOS)))
goto nla_put_failure;
}
NLA_PUT(msg, i, sizeof(egress_qos[i]), &egress_qos[i]);
NLA_PUT(msg, IFLA_VLAN_QOS_MAPPING, sizeof(egress_qos[i]), &egress_qos[i]);
}
}