From 18b903943d3c7fb81eded28dfe92c96bb661cd86 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Wed, 13 May 2020 22:12:09 +0200 Subject: [PATCH] cli: fix memcpy() with %NULL pointers in nmc_get_devices_sorted() UBSan correctly flags this: clients/cli/devices.c:966:2: runtime error: null pointer passed as argument 2, which is declared to never be null --- clients/cli/devices.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/clients/cli/devices.c b/clients/cli/devices.c index 2d79d2ae9a..4998ff032e 100644 --- a/clients/cli/devices.c +++ b/clients/cli/devices.c @@ -963,7 +963,8 @@ nmc_get_devices_sorted (NMClient *client) devs = nm_client_get_devices (client); sorted = g_new (NMDevice *, devs->len + 1); - memcpy (sorted, devs->pdata, devs->len * sizeof (NMDevice *)); + if (devs->len > 0) + memcpy (sorted, devs->pdata, devs->len * sizeof (NMDevice *)); sorted[devs->len] = NULL; qsort (sorted, devs->len, sizeof (NMDevice *), compare_devices);