From 17e4da8bf36205df773c0aff6fbceeea38dab3b5 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Thu, 16 Sep 2021 08:40:04 +0200 Subject: [PATCH] device: suppress warning for external device if it is down (!IFF_UP) External devices are not to be touched by NetworkManager. If it is down, that is not something to warn about. --- src/core/devices/nm-device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/core/devices/nm-device.c b/src/core/devices/nm-device.c index 0ee21bfb82..8e13692703 100644 --- a/src/core/devices/nm-device.c +++ b/src/core/devices/nm-device.c @@ -11641,7 +11641,8 @@ activate_stage3_ip_config_start(NMDevice *self) nm_device_state_changed(self, NM_DEVICE_STATE_IP_CONFIG, NM_DEVICE_STATE_REASON_NONE); /* Device should be up before we can do anything with it */ - if ((ifindex = nm_device_get_ip_ifindex(self)) > 0 + if (!nm_device_sys_iface_state_is_external(self) + && (ifindex = nm_device_get_ip_ifindex(self)) > 0 && !nm_platform_link_is_up(nm_device_get_platform(self), ifindex)) _LOGW(LOGD_DEVICE, "interface %s not up for IP configuration",