From 16e0f38c3eee08e03cb71342d9208c1b41a725a5 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Tue, 22 Jan 2019 11:40:59 +0100 Subject: [PATCH] clients/secret-agent: cancel pending operations We must actually cancel the GCancellable. Otherwise, the pending async operations are not cancelled. _auth_dialog_write_done() doesn't care about that, but _auth_dialog_read_done() does. It must not touch the destroyed data, after the operation is cancelled. --- clients/common/nm-secret-agent-simple.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clients/common/nm-secret-agent-simple.c b/clients/common/nm-secret-agent-simple.c index ba20d489a3..72c5057cc1 100644 --- a/clients/common/nm-secret-agent-simple.c +++ b/clients/common/nm-secret-agent-simple.c @@ -91,7 +91,7 @@ _request_data_free (gpointer data) RequestData *request = data; g_free (request->request_id); - g_object_unref (request->cancellable); + nm_clear_g_cancellable (&request->cancellable); g_object_unref (request->self); g_object_unref (request->connection); g_strfreev (request->hints);