From 15fb8fe26deb8bee99b06662d7624adc06f8d162 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Thu, 5 Dec 2019 12:27:13 +0100 Subject: [PATCH] settings/trivial: add fixme comment for creating GDBusConnection for ifcfg D-Bus interface We really should just use the one and only main connection. --- src/settings/plugins/ifcfg-rh/nms-ifcfg-rh-plugin.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/settings/plugins/ifcfg-rh/nms-ifcfg-rh-plugin.c b/src/settings/plugins/ifcfg-rh/nms-ifcfg-rh-plugin.c index f57ca1a7b2..453307ad85 100644 --- a/src/settings/plugins/ifcfg-rh/nms-ifcfg-rh-plugin.c +++ b/src/settings/plugins/ifcfg-rh/nms-ifcfg-rh-plugin.c @@ -1132,6 +1132,8 @@ _dbus_setup (NMSIfcfgRHPlugin *self) _dbus_clear (self); + /* FIXME: we don't need a separate GDBusConnection. Just reuse the one from + * nm_dbus_manager_get_dbus_connection(). */ address = g_dbus_address_get_for_bus_sync (G_BUS_TYPE_SYSTEM, NULL, &error); if (address == NULL) { _LOGW ("dbus: failed getting address for system bus: %s", error->message);