From 15c25e91f5a59d284ef99053bcb695c9843c5e31 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Thu, 30 Mar 2023 14:41:31 +0200 Subject: [PATCH] client/tests: skip cloud-setup test for older python The test uses subprocess.Popen()'s "pass_fd" argument. That is only available since Python 3.2. Possibly it could be solved differently, but that is not implemented. Instead, skip the test. Also, socket.socket.set_inheritable() is Python 3.4. But presumably we don't need it. Fixes: d89d42bf2317 ('tests/client: test nm-cloud-setup') --- src/tests/client/test-client.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/tests/client/test-client.py b/src/tests/client/test-client.py index e603203e3e..31cfbb0e1e 100755 --- a/src/tests/client/test-client.py +++ b/src/tests/client/test-client.py @@ -2146,6 +2146,10 @@ class TestNmCloudSetup(TestNmClient): if pexpect is None: raise unittest.SkipTest("pexpect not available") + if tuple(sys.version_info[0:2]) < (3, 2): + # subprocess.Popen()'s "pass_fd" argument requires at least Python 3.2. + raise unittest.SkipTest("This test requires at least Python 3.2") + s = socket.socket() s.set_inheritable(True) s.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)