fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-01-04 05:10:17 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

settings: fix memleak in agent_secrets_done_cb()

Browse source 
Fixes: df6706813a
This commit is contained in:
Thomas Haller 2015-09-02 17:10:58 +02:00
parent 71c8c2e587
commit 158b32b7e0
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/settings/nm-settings-connection.c
View file

@ -138,6 +138,8 @@ typedef struct {
typedef gboolean (*ForEachSecretFunc) (NMSettingSecretFlags flags,
gpointer user_data);
/* Returns always a non-NULL, non-floating variant that must
* be unrefed by the caller. */
static GVariant *
for_each_secret (NMConnection *self,
GVariant *secrets,
@ -224,7 +226,7 @@ for_each_secret (NMConnection *self,
g_variant_builder_add (&secrets_builder, "{sa{sv}}", setting_name, &setting_builder);
}
return g_variant_builder_end (&secrets_builder);
return g_variant_ref_sink (g_variant_builder_end (&secrets_builder));
}
typedef gboolean (*FindSecretFunc) (NMSettingSecretFlags flags,
@ -923,7 +925,6 @@ agent_secrets_done_cb (NMAgentManager *manager,
call_id);
}
g_variant_unref (filtered_secrets);
} else {
_LOGD ("(%s:%u) failed to update with agent secrets: (%d) %s",
setting_name,
@ -931,6 +932,7 @@ agent_secrets_done_cb (NMAgentManager *manager,
local ? local->code : -1,
(local && local->message) ? local->message : "(unknown)");
}
g_variant_unref (filtered_secrets);
} else {
_LOGD ("(%s:%u) failed to update with existing secrets: (%d) %s",
setting_name,