From 151dbe10b1cda511fb8cf8e41e4baa292563ff8a Mon Sep 17 00:00:00 2001 From: Beniamino Galvani Date: Mon, 12 Dec 2016 14:10:23 +0100 Subject: [PATCH] manager: don't update the manager state in get_property() The manager state is already computed every time an active connection changes state, it is not necessary to call nm_manager_update_state() also when the property is read. Moreover, nm_manager_update_state() emits a "notify::state" signal which causes a re-read of the property by the nm-exported-object, resulting in a nested execution of nm_manager_update_state(). (cherry picked from commit 4cc45ee291e78a58e3a69c6f21fe09d61781f591) --- src/nm-manager.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/nm-manager.c b/src/nm-manager.c index ad1e48e85e..a9a44ea5ef 100644 --- a/src/nm-manager.c +++ b/src/nm-manager.c @@ -5655,7 +5655,6 @@ get_property (GObject *object, guint prop_id, g_value_set_string (value, VERSION); break; case PROP_STATE: - nm_manager_update_state (self); g_value_set_uint (value, priv->state); break; case PROP_STARTUP: