From 123765befcad75e1a77d2d8f0e2e1971b925c28e Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Fri, 8 Jan 2021 11:11:28 +0100 Subject: [PATCH] shared: add code comment to nm_clear_g_object() --- shared/nm-glib-aux/nm-macros-internal.h | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/shared/nm-glib-aux/nm-macros-internal.h b/shared/nm-glib-aux/nm-macros-internal.h index 1fdf6999e4..4ce787ad1d 100644 --- a/shared/nm-glib-aux/nm-macros-internal.h +++ b/shared/nm-glib-aux/nm-macros-internal.h @@ -1038,6 +1038,14 @@ nm_g_object_unref(gpointer obj) */ #define nm_clear_g_free(pp) nm_clear_pointer(pp, g_free) +/* Our nm_clear_pointer() is more typesafe than g_clear_pointer() and + * should be preferred. + * + * For g_clear_object() that is not the case (because g_object_unref() + * anyway takes a void pointer). So using g_clear_object() is fine. + * + * Still have a nm_clear_g_object() because that returns a boolean + * indication whether anything was cleared. */ #define nm_clear_g_object(pp) nm_clear_pointer(pp, g_object_unref) /**