From 0ff3699af5aaf9e403964bf6b52db30f78e2f069 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Wed, 11 Nov 2015 18:00:33 +0100 Subject: [PATCH] Revert "wifi: do no crash when getting BSSID fails" Since commit ebe3320e62e6f4068467f2410b93be2a05ff6d53, nm_ap_new_from_properties() will always return an AP with BSSID set. Restore the assertion during try_fill_ssid_for_hidden_ap(). This reverts commit e0e043ef3918de54f8d19a3af07d3367962970e5. (cherry picked from commit d5373959f9245faeebb1ba32b5b2b688d073ee6c) --- src/devices/wifi/nm-device-wifi.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/devices/wifi/nm-device-wifi.c b/src/devices/wifi/nm-device-wifi.c index 6f63756cbf..3c4ca9b141 100644 --- a/src/devices/wifi/nm-device-wifi.c +++ b/src/devices/wifi/nm-device-wifi.c @@ -1649,11 +1649,7 @@ try_fill_ssid_for_hidden_ap (NMAccessPoint *ap) g_return_if_fail (nm_ap_get_ssid (ap) == NULL); bssid = nm_ap_get_address (ap); - if (!bssid) { - nm_log_dbg (LOGD_WIFI, "failed to get BSSID for hidden AP %s", - str_if_set (nm_ap_get_supplicant_path (ap), "(none)")); - return; - } + g_return_if_fail (bssid); /* Look for this AP's BSSID in the seen-bssids list of a connection, * and if a match is found, copy over the SSID */