fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-01-11 07:30:16 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

auth-manager: fix processing calls in _dbus_new_proxy_cb()

Browse source 
In the first loop, the element is removed only when the callback is
executed. The second loop never removes the current element. Use the
for_each macro for both.

Fixes: d0563f0733
This commit is contained in:
Beniamino Galvani 2018-04-17 16:17:40 +02:00
parent cbeabaa000
commit 0fa57069ad
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/nm-auth-manager.c
View file

@ -500,7 +500,7 @@ _dbus_new_proxy_cb (GObject *source_object,
NMAuthManagerPrivate *priv;
gs_free GError *error = NULL;
GDBusProxy *proxy;
NMAuthManagerCallId *call_id;
NMAuthManagerCallId *call_id, *safe;
proxy = g_dbus_proxy_new_for_bus_finish (res, &error);
@ -516,7 +516,7 @@ _dbus_new_proxy_cb (GObject *source_object,
if (!priv->proxy) {
_LOGE ("could not create polkit proxy: %s", error->message);
while ((call_id = c_list_first_entry (&priv->calls_lst_head, NMAuthManagerCallId, calls_lst))) {
c_list_for_each_entry_safe (call_id, safe, &priv->calls_lst_head, calls_lst) {
if (call_id->dbus_parameters) {
_LOG2T (call_id, "completed: failed due to no D-Bus proxy after startup");
_call_id_invoke_callback (call_id, FALSE, FALSE, error);
@ -537,7 +537,7 @@ _dbus_new_proxy_cb (GObject *source_object,
_log_name_owner (self, NULL);
while ((call_id = c_list_first_entry (&priv->calls_lst_head, NMAuthManagerCallId, calls_lst))) {
c_list_for_each_entry (call_id, &priv->calls_lst_head, calls_lst) {
if (call_id->dbus_parameters) {
_LOG2T (call_id, "CheckAuthorization invoke now");
_call_check_authorize (call_id);