From 0ee60b943d07dcbbc8507e346175bac9bb49bd6d Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Thu, 30 Mar 2023 20:50:29 +0200 Subject: [PATCH] ovsdb: downgrade error logging to warnings is mostly about "really should not happen" scenarios. It's closer to an assertion failure, and something that NetworkManager should not happen. Of course, things can go wrong, but is a sufficient. When ovsdb gives unexpected communication, it's just a warning. At least, that's also what all the similar cases in "nm-ovsdb.c" already do --- src/core/devices/ovs/nm-ovsdb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/core/devices/ovs/nm-ovsdb.c b/src/core/devices/ovs/nm-ovsdb.c index dc8bf289fe..8c463106fd 100644 --- a/src/core/devices/ovs/nm-ovsdb.c +++ b/src/core/devices/ovs/nm-ovsdb.c @@ -2274,13 +2274,13 @@ ovsdb_got_msg(NMOvsdb *self, json_t *msg) /* This is a response to a method call. */ if (c_list_is_empty(&priv->calls_lst_head)) { - _LOGE("there are no queued calls expecting response %" G_GUINT64_FORMAT, (guint64) id); + _LOGW("there are no queued calls expecting response %" G_GUINT64_FORMAT, (guint64) id); ovsdb_disconnect(self, FALSE, FALSE); return; } call = c_list_first_entry(&priv->calls_lst_head, OvsdbMethodCall, calls_lst); if (call->call_id != id) { - _LOGE("expected a response to call %" G_GUINT64_FORMAT ", not %" G_GUINT64_FORMAT, + _LOGW("expected a response to call %" G_GUINT64_FORMAT ", not %" G_GUINT64_FORMAT, call->call_id, (guint64) id); ovsdb_disconnect(self, FALSE, FALSE);