From 0cd20f94d09b9d87526dd131219eac17a594271a Mon Sep 17 00:00:00 2001 From: Beniamino Galvani Date: Tue, 15 Jun 2021 19:40:34 +0200 Subject: [PATCH] firewall: fix double free Fixes: 9ebdb967ded7 ('firewall: implement masquerading for shared mode with nftables') --- src/core/nm-firewall-utils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/core/nm-firewall-utils.c b/src/core/nm-firewall-utils.c index cee4eebf8a..3f2251569f 100644 --- a/src/core/nm-firewall-utils.c +++ b/src/core/nm-firewall-utils.c @@ -372,7 +372,7 @@ _fw_nft_call_data_free(FwNftCallData *call_data, GError *error_take) nm_clear_g_source_inst(&call_data->timeout_source); if (error_take) - g_task_return_error(call_data->task, g_steal_pointer(&error_take)); + g_task_return_error(call_data->task, error_take); else g_task_return_boolean(call_data->task, TRUE); @@ -455,7 +455,7 @@ _fw_nft_call_communicate_cb(GObject *source, GAsyncResult *result, gpointer user "")); } - _fw_nft_call_data_free(call_data, error); + _fw_nft_call_data_free(call_data, g_steal_pointer(&error)); } static void