From 0a428556e55373147cf6dc08ab1e7304a1714e33 Mon Sep 17 00:00:00 2001 From: Paul Menzel Date: Wed, 6 May 2026 12:23:11 +0200 Subject: [PATCH] core: add libndp_dep to libNetworkManagerBase dependencies MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `nm-lndp-ndisc.c` includes `` but libndp_dep is missing from libNetworkManagerBase's dependency list, causing compilation failures when libndp development files is not installed in the default include path. $ PKG_CONFIG_PATH=/scratch/local2/Apmenzel/nm-dependencies/lib/pkgconfig meson setup -Dselinux=false /dev/shm/nm-build […] $ ninja -C /dev/shm/nm-build […] [572/932] Compiling C object src/core/libNetworkManagerBase.a.p/ndisc_nm-lndp-ndisc.c.o FAILED: src/core/libNetworkManagerBase.a.p/ndisc_nm-lndp-ndisc.c.o cc -Isrc/core/libNetworkManagerBase.a.p -Isrc/core -I../../../../home/Apmenzel/src/NetworkManager2/src/core -Isrc -I../../../../home/Apmenzel/src/NetworkManager2/src -I. -I../../../../home/Apmenzel/src/NetworkManager2 -Isrc/libnm-core-public -I../../../../home/Apmenzel/src/NetworkManager2/src/libnm-core-public -I/usr/include/gio-unix-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -fdata-sections -ffunction-sections -Wcast-align=strict -Wdeclaration-after-statement -Wfloat-equal -Wformat-nonliteral -Wformat-security -Wimplicit-function-declaration -Wimplicit-int -Winit-self -Wint-conversion -Wlogical-op -Wmissing-declarations -Wmissing-include-dirs -Wmissing-prototypes -Wold-style-definition -Wpointer-arith -Wshadow -Wshift-negative-value -Wstrict-prototypes -Wundef -Wvla -Wno-duplicate-decl-specifier -Wno-format-truncation -Wno-format-y2k -Wno-missing-field-initializers -Wno-pragmas -Wno-sign-compare -Wno-unknown-pragmas -Wno-unused-parameter -fno-strict-aliasing -Wimplicit-fallthrough -fPIC -pthread -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_42 -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_42 -MD -MQ src/core/libNetworkManagerBase.a.p/ndisc_nm-lndp-ndisc.c.o -MF src/core/libNetworkManagerBase.a.p/ndisc_nm-lndp-ndisc.c.o.d -o src/core/libNetworkManagerBase.a.p/ndisc_nm-lndp-ndisc.c.o -c ../../../../home/Apmenzel/src/NetworkManager2/src/core/ndisc/nm-lndp-ndisc.c ../../../../home/Apmenzel/src/NetworkManager2/src/core/ndisc/nm-lndp-ndisc.c:13:10: fatal error: ndp.h: No such file or directory 13 | #include | ^~~~~~~ compilation terminated. […] Co-Authored-By: Claude Sonnet 4.6 --- src/core/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/src/core/meson.build b/src/core/meson.build index 4a3dfd8e11..b495940cfc 100644 --- a/src/core/meson.build +++ b/src/core/meson.build @@ -68,6 +68,7 @@ libNetworkManagerBase = static_library( dependencies: [ core_default_dep, libnm_core_public_dep, + libndp_dep, libsystemd_dep, libudev_dep, ] + base_deps_addon,