From 0822cbb032ea224bbc125861578f0eaec08dd711 Mon Sep 17 00:00:00 2001 From: Lubomir Rintel Date: Wed, 18 Jan 2017 11:28:35 +0100 Subject: [PATCH] libnm/object: lower the severity of the dangling object warning The user can't do much about it and we can recover. This is a temporary measure to avoid unnecessarily bothering the user. (cherry picked from commit 7fec0755c9072dc37140a7b63b491ed02a3539cd) --- libnm/nm-object.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/libnm/nm-object.c b/libnm/nm-object.c index a5eccbdc34..6a47c65941 100644 --- a/libnm/nm-object.c +++ b/libnm/nm-object.c @@ -596,7 +596,18 @@ handle_object_property (NMObject *self, const char *property_name, GVariant *val if (!object) { /* This is a server bug -- a dangling object path for an object * that does not exist. */ - g_warning ("No object known for %s", path); + /* XXX: We've ignored this before and the server hits the condition + * more often that it should. Given we're able to recover from + * ther error, let's lower the severity of the log message to + * avoid unnecessarily bothering the user. This can be removed + * once the issue is fixed on the server. */ +#if NM_MORE_ASSERTS +#define __nm_log_debug g_warning +#else +#define __nm_log_debug g_debug +#endif + __nm_log_debug ("No object known for %s", path); +#undef __nm_log_debug return FALSE; }