From 0718b2550832aee2543f7102c3c6adc2cdbeef8d Mon Sep 17 00:00:00 2001 From: Lubomir Rintel Date: Thu, 17 Aug 2017 12:51:52 +0200 Subject: [PATCH] clients: allow GSM and CDMA for Bluetooth connections Unbreaks Bluetooth DUN. Probably broken with the nm-meta-setting-desc refactor, hence the Fixes tag. I didn't actually check. $ nmcli c add type bluetooth ifname '*' bluetooth.bdaddr 1C:E2:CC:56:6C:45 connection.id bt bt-type dun-gsm Error: 'apn' argument is required. $ nmcli c add type bluetooth ifname '*' bluetooth.bdaddr 1C:E2:CC:56:6C:45 connection.id bt bt-type dun-gsm apn internet Error: invalid . 'apn'. $ This is where it starts to get sad ^ $ nmcli c add type bluetooth ifname '*' bluetooth.bdaddr 1C:E2:CC:56:6C:45 connection.id bt bt-type dun-gsm gsm.apn internet Error: invalid or not allowed setting 'gsm': 'gsm' not among [connection, bluetooth, bridge, ipv4, ipv6, proxy]. $ This is where it gets obvious what went wrong ^ Fixes: b5c8622ad3e8eb34143e5023cdf784da741f338c --- clients/common/nm-meta-setting-desc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/clients/common/nm-meta-setting-desc.c b/clients/common/nm-meta-setting-desc.c index 9d68b23334..f577ebdc3b 100644 --- a/clients/common/nm-meta-setting-desc.c +++ b/clients/common/nm-meta-setting-desc.c @@ -6805,6 +6805,8 @@ const NMMetaSettingInfoEditor nm_meta_setting_infos_editor[] = { NM_META_SETTING_VALID_PART_ITEM (CONNECTION, TRUE), NM_META_SETTING_VALID_PART_ITEM (BLUETOOTH, TRUE), NM_META_SETTING_VALID_PART_ITEM (BRIDGE, FALSE), + NM_META_SETTING_VALID_PART_ITEM (GSM, FALSE), + NM_META_SETTING_VALID_PART_ITEM (CDMA, FALSE), ), .setting_init_fcn = _setting_init_fcn_bluetooth, ),