fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-04-24 23:10:49 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

dhcp: clean source on dispatch failure (fix leak)

Browse source 
The GSource must also be unrefed. Also, first clear the field
before invoking callbacks to the upper layers.

Fixes: 843d696e46 ('dhcp: clean source on dispatch failure')
This commit is contained in:
Thomas Haller 2020-03-03 09:50:43 +01:00
parent 843d696e46
commit 0549351111
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/dhcp/nm-dhcp-nettools.c
View file

@ -1072,8 +1072,8 @@ dhcp4_event_cb (int fd,
* a predefined number of times (possibly infinite).
*/
_LOGE ("error %d dispatching events", r);
nm_clear_g_source_inst (&priv->event_source);
nm_dhcp_client_set_state (NM_DHCP_CLIENT (self), NM_DHCP_STATE_FAIL, NULL, NULL);
priv->event_source = NULL;
return G_SOURCE_REMOVE;
}