From 03502cf5bfae3c2b1dcfb53cfd498c1e352a1a84 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Mon, 18 Mar 2019 15:51:10 +0100 Subject: [PATCH] cli/trivial: add code comment about nmc_value_transforms_register() --- clients/common/nm-meta-setting-desc.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/clients/common/nm-meta-setting-desc.c b/clients/common/nm-meta-setting-desc.c index 57f0967285..aa9ada751d 100644 --- a/clients/common/nm-meta-setting-desc.c +++ b/clients/common/nm-meta-setting-desc.c @@ -759,6 +759,12 @@ _get_fcn_gobject_impl (const NMMetaPropertyInfo *property_info, s_c = b ? "yes" : "no"; return s_c; } else { + /* Note that we register certain transform functions in nmc_value_transforms_register(). + * This makes G_TYPE_STRV working. + * + * FIXME: that is particularly ugly because it's non-obvious which code relies + * on nmc_value_transforms_register(). Also, nmc_value_transforms_register() is + * in clients/cli, while we are here in clients/common. */ g_value_init (&val, G_TYPE_STRING); g_object_get_property (G_OBJECT (setting), property_info->property_name, &val); s = g_value_dup_string (&val);